feat: team issue assignment #27370
Merged
feat: team issue assignment #27370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +190 B (+0.02%) Total Size: 1.13 MB ℹ️ View Unchanged
|
daibhin
commented
Jan 9, 2025
Comment on lines
83
to
86
| migrations.AddConstraint( | ||
| model_name="errortrackingissueassignment", | ||
| constraint=models.UniqueConstraint(fields=("issue",), name="unique_per_issue"), | ||
| ), |
There was a problem hiding this comment.
Some of these constraints are causing the checks to fail due to table locking. Given this table is tiny right now it feels easier to override the check than go about writing the custom up / down SQL by hand cc @neilkakkar
There was a problem hiding this comment.
yeah i think will be fine 👍
daibhin
commented
Jan 13, 2025
| self.assertEqual([x["id"] for x in results], [issue_id]) | ||
|
|
||
| @snapshot_clickhouse_queries | ||
| def test_user_group_assignee(self): |
There was a problem hiding this comment.
Only actual new test in this file. Everything else is just a cleanup
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Issues belong to teams not individuals sometimes. Let's add the concept of a team within error tracking and offer the ability to assign to more than one person
Changes
Decided to go with explicit
useranderror_tracking_teamcolumns on the assignment model rather than something polymorphic / generic because of https://lukeplant.me.uk/blog/posts/avoid-django-genericforeignkey/