Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor-3001): show header on mobile for editor #27373

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Jan 8, 2025

Problem

  • sidebar is completely hidden on mobile layout

Changes

  • show header
  • banners will also show up above the editor scene until dismissed
Screenshot 2025-01-08 at 3 48 44 PM

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

Copy link
Member

@rafaeelaudibert rafaeelaudibert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure hope this doesn't break everything :)

Thanks!

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Size Change: 0 B

Total Size: 1.11 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.11 MB

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

72 snapshot changes in total. 0 added, 72 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants