Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(created-by-sources): Adding created_by to sources #27751

Merged
merged 5 commits into from
Jan 22, 2025

Conversation

phixMe
Copy link
Contributor

@phixMe phixMe commented Jan 21, 2025

Problem

We aren't attributing users to sources at this time and the column is just null in every case.

No updates for the UI as we're actually going to be missing this data for everything created before this is merged, but better to capture the data now then capture for everything moving forward.

Current Situation:

{
    "id": "01948a8e-9f5c-0000-f256-b89f1462cdd3",
    "created_at": "2025-01-21T20:29:50.300616Z",
    "created_by": null,
    "status": "Running",
    "source_type": "Postgres",
    "prefix": "",
    "last_run_at": null,
    "schemas": [
        {...}
    ]
}

Changes

  • Add field to creation id
  • Hydrate id to object in response

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

API works and correctly links the id --> email once it's returned to the user.

@phixMe phixMe changed the title Fix(created-by-sources): Adding created_by to sources fix(created-by-sources): Adding created_by to sources Jan 21, 2025
@phixMe phixMe requested a review from a team January 22, 2025 00:14
@phixMe phixMe marked this pull request as ready for review January 22, 2025 00:21
@phixMe phixMe merged commit 7f49417 into master Jan 22, 2025
96 checks passed
@phixMe phixMe deleted the fix(created-by-sources) branch January 22, 2025 16:53
fuziontech added a commit that referenced this pull request Jan 22, 2025
* master: (103 commits)
  feat(postgres-estimated-rows): pg Estimated Rows on Data Warehouse Sync (#27634)
  fix: revert darkmode class toggle, updated content on fills (#27783)
  chore: upgrade posthog-js (#27790)
  chore(editor-3001): add back join actions (#27740)
  feat: Add person distinct ID overrides squash job (as dagster job) (#27710)
  fix(created-by-sources): Adding `created_by` to sources (#27751)
  Revert "feat(data-warehouse): V2 pipeline release " (#27791)
  fix: typo for feature flags (#27786)
  fix(defer-unmounting): Defer unmounting of react elements (#27742)
  feat(data-warehouse): V2 pipeline release (#27732)
  fix(data-warehouse): Ensure dates are actual datetime formats (#27777)
  fix: enable hot reload for the products dir (#27746)
  fix: assignee selector when null (#27737)
  chore: clarify rrweb imports (#27776)
  chore(deps): Update posthog-js to 1.207.3 (#27779)
  feat(retention): filters on start/return event (#27770)
  fix(experiments): only show supported math functions (#27589)
  feat(web-analytics): Set unique conversions graph when adding conversions goal (#27774)
  chore: color design system part 1: banner and accents (#27756)
  chore(experiments): Add tests for funnel attribution options (#27752)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants