fix: improve the styling and responsiveness #27859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veryayskiy
changed the title
veryayskiy
changed the title
|
Size Change: 0 B Total Size: 1.16 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated10 snapshot changes in total. 0 added, 10 modified, 0 deleted:
Triggered by this commit. |
pauldambra
reviewed
Jan 24, 2025
| <ShowMouseTail /> | ||
| <SetPlaybackSpeed /> | ||
| <SetTimeFormat /> | ||
| <SettingsBar border="top"> |
There was a problem hiding this comment.
bottom border as well? I think this takes "both"
pauldambra
reviewed
Jan 24, 2025
| @@ -174,20 +175,25 @@ function InspectDOM(): JSX.Element { | |||
| ) | |||
| } | |||
|
|
|||
| function PlayerBottomSettings(): JSX.Element { | |||
| export function PlayerBottomSettings(): JSX.Element { | |||
There was a problem hiding this comment.
it's maybe more of a PlayerSettings now than PlayerBottomSettings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Player has the bottom settings that include a bunch of useful buttons such as speed, skip inactivity, etc.
Problem:
When there is a banner on the top (e.g update SDK or Invite a team member) those buttons are not visible.
Solution:
Move them to the top + move "Activity" button there as well.
Before:
After:
