Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sidebar-text-highlight): Improve component to highlight text and use in navigation #27894

Merged
merged 4 commits into from
Jan 28, 2025

Conversation

phixMe
Copy link
Contributor

@phixMe phixMe commented Jan 25, 2025

Problem

Old component relied on parent derived state to calculate ranges and would not be suitable for a unit test or usable outside the context of this specific place in our application.

image

Changes

-[x] Rewrite component to be self-contained, usable elsewhere, and retain it's
-[x] The component correctly inside the list renderer.

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Text now highlights and provides a cleaner and more ubiquitous interface.

Copy link
Contributor

github-actions bot commented Jan 25, 2025

Size Change: -10 B (0%)

Total Size: 1.16 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.16 MB -10 B (0%)

compressed-size-action

@phixMe phixMe requested a review from a team January 28, 2025 16:54
@phixMe phixMe merged commit 585165b into master Jan 28, 2025
99 checks passed
@phixMe phixMe deleted the fix(source-highlight) branch January 28, 2025 18:48
adamleithp pushed a commit that referenced this pull request Jan 29, 2025
adamleithp pushed a commit that referenced this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants