chore: merge project permissions into advanced permissions #28115
+25
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
|
Size Change: +5 B (0%) Total Size: 1.16 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated6 snapshot changes in total. 0 added, 6 modified, 0 deleted:
Triggered by this commit. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR consolidates project-based permissions into advanced permissions across the PostHog codebase. Here's a summary of the key changes:
- Removes
PROJECT_BASED_PERMISSIONINGfeature flag and merges its functionality intoADVANCED_PERMISSIONSacross all files - Updates feature checks in access control components and logic to use
ADVANCED_PERMISSIONSinstead ofPROJECT_BASED_PERMISSIONING - Maintains existing functionality since both features were previously available on the same plans
- Aligns with new RBAC/access control system where permissions will be available through teams add-on
- Includes comprehensive test updates to verify permission system still works correctly after consolidation
Key points to review:
- TODO comment on line 115 in AccessControlObject.tsx about index mapping needs to be addressed
- Migration path for existing installations should be verified to ensure smooth transition
- Documentation and frontend code references to
PROJECT_BASED_PERMISSIONINGneed to be updated - Legacy test classes that are commented out should be reviewed for proper migration to new system
16 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
benjackwhite
approved these changes
Jan 31, 2025
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Follow along on RBAC: #24512
Billing PR to be shipped after this: https://github.com/PostHog/billing/pull/1092
Deprecating
project_based_permissioningand merging intoadvanced_permissions.Currently
advanced_permissionsis used for dashboard permissions andproject_based_permissioningis used for permissions around projects like private projects. With the new RBAC / access control system we are merging these together and they will be available on the teams add-on.Since both of these are available on the same plans right now, this should have no affect to users. I confirmed that every plan that has
advanced_permissionsalso hasproject_based_permissioningand vice versa.👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
It doesn't have an impact.
How did you test this code?