feat: custom /query rate limit when using personal API key #28184
+670
−253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds a new team property api_query_rate_limit to enable customizable rate limits for API queries when using personal API keys. Here are the key changes:
- Added
api_query_rate_limitCharField to Team model with validation for rate limit formats like '100/hour', '5/min' - Modified
PersonalApiKeyRateThrottleclass to support custom rate limits through newload_team_rate_limitmethod - Added validation function
validate_rate_limitin utils.py to ensure proper rate limit format using regex pattern - Created migration 0559 to add the new nullable field with max length of 32 characters
- Added test cases to verify rate limit format validation rejects invalid formats like '1/week' while accepting valid ones like '1/s'
The implementation looks solid but there are a few potential concerns:
- Consider adding documentation on supported rate limit formats and validation rules
- The commented-out test exception in query.py should be removed
- May want to add validation to prevent extremely high rate limits that could impact system stability
10 file(s) reviewed, 10 comment(s)
Edit PR Review Bot Settings | Greptile
| "set custom rate limit", extra={"rate_limit_cache_key": rate_limit_cache_key, "rate_limit": self.rate} | ||
| ) | ||
|
|
||
| self.num_requests, self.duration = self.parse_rate(self.rate) |
There was a problem hiding this comment.
logic: parse_rate() could raise ValueError for invalid rate string formats. Add error handling here.
orian
force-pushed
the
pawel/feat/team-rate-limit
branch
3 times, most recently
from
1121456 to
a1e3353
Compare
orian
changed the title
orian
force-pushed
the
pawel/feat/team-rate-limit
branch
from
ebbf909 to
db97a9c
Compare
orian
force-pushed
the
pawel/feat/team-rate-limit
branch
from
83184fe to
5d6fab2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some users want to send more than 120 queries per hour.
Changes
Does this work well for both Cloud and self-hosted?
Yes.
How did you test this code?
Added test and check locally.