Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase the receive_timeout to 24 hours for delete job #28231

Merged
merged 3 commits into from
Feb 3, 2025
Merged

fix: increase the receive_timeout to 24 hours for delete job #28231

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7d7338
fix: increase the recieve_timeout to 24 hours for delete job
fuziontech Feb 3, 2025
e4fe8e1
keep the dict setting separate
fuziontech Feb 3, 2025
1cbb8c9
set zk path based on if tests (since multiple tables creations are po…
fuziontech Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions dags/deletes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ class ClickhouseClusterResource(ConfigurableResource):
client_settings: dict[str, str] = {
"max_execution_time": "0",
"max_memory_usage": "0",
"receive_timeout": f"{10 * 60}",
"receive_timeout": f"{24 * 60 * 60}", # wait 24 hours for a response from CH
"mutations_sync": "0",
"lightweight_deletes_sync": "0",
}

def create_resource(self, context: InitResourceContext) -> ClickhouseCluster:
Expand All @@ -60,17 +62,13 @@ class DeleteConfig(Config):
)
max_execution_time: int = pydantic.Field(
default=0,
description="The maximum amount of time to wait for the dictionary to be loaded before considering the operation "
description="The maximum amount of time to wait for any step to complete before considering the operation "
"a failure, or 0 to wait an unlimited amount of time.",
)
max_memory_usage: int = pydantic.Field(
default=0,
description="The maximum amount of memory to use for the dictionary, or 0 to use an unlimited amount.",
)
lightweight_deletes_sync: int = pydantic.Field(
default=0,
description="0 is async. 1 is local sync. 2 is cluster sync.",
)

@property
def parsed_timestamp(self) -> datetime:
Expand Down Expand Up @@ -168,7 +166,6 @@ def checksum(self, client: Client):
@dataclass
class PendingDeletesDictionary:
source: PendingPersonEventDeletesTable
lightweight_deletes_sync: int = 0

@property
def name(self) -> str:
Expand Down Expand Up @@ -258,7 +255,6 @@ def delete_mutation_runner(self) -> MutationRunner:
timestamp <= dictGet('{self.qualified_name}', 'created_at', (team_id, person_id))
""",
{},
settings={"mutations_sync": self.lightweight_deletes_sync},
)


Expand Down Expand Up @@ -381,7 +377,6 @@ def sync_replica(client: Client):

del_dict = PendingDeletesDictionary(
source=load_pending_person_deletions,
lightweight_deletes_sync=config.lightweight_deletes_sync,
)

cluster.any_host_by_role(
Expand Down