fix: friendlier label names for feature flags property targetting #28301
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Enhanced feature flag property targeting UI by adding human-readable labels for property keys in the feature flag conditions display.
- Added
getFilterLabelfunction call infrontend/src/scenes/feature-flags/FeatureFlagReleaseConditions.tsxto show descriptive labels (e.g. "Latest Current URL" instead of "$current_url") - Modified read-only property display to show both friendly label and technical key for better clarity
- Improved UX by making property targeting conditions more understandable for non-technical users
1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
| {property?.type !== 'cohort' && | ||
| getFilterLabel( | ||
| property.key, | ||
| property.type === 'person' | ||
| ? TaxonomicFilterGroupType.PersonProperties | ||
| : TaxonomicFilterGroupType.EventProperties | ||
| )} |
There was a problem hiding this comment.
logic: The property type check should also handle group properties, not just person and event properties
There was a problem hiding this comment.
why do we filter type !== 'cohort'?
should we also consider group properties?
There was a problem hiding this comment.
for cohort, I don't think we need the helper table:
also for group properties, I thought we only had person properties and cohorts for filtering. Looked on the feature flags page too:
|
Size Change: 0 B Total Size: 1.17 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
lucasheriques
deleted the
fix/more-friendly-label-names-for-property-targetting
branch
Problem
adds the friendlier label name to the feature flag conditions match, so users don't have to set a "Latest Current URL" and then see just a
$current_urlkey which doesn't carry a lot of meaning.Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Verified locally, no logic changes