Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(paths): improve paths visualization #28338

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

thmsobrmlr
Copy link
Contributor

@thmsobrmlr thmsobrmlr commented Feb 5, 2025

Problem

Changes

Screenshot 2025-02-07 at 09 44 47
  • come up with better dummy-data
  • use a single color, instead of having red links (already implemented with insight-colors)
  • use a darker color for hover (like trend bars), instead of using data-color-2
  • node: wider and rounded corners
  • add a padding to the chart canvas
  • column: larger padding between nodes
  • node height proportional to absolute numbers
  • show all cards
  • add a dropoff node, instead of the current dropoff path
  • add a header column "intial pageview > next page > page + 1"
  • make columns fixed width and add a scroll behaviour
  • improve hover effect
    • hover on node should be possible
    • hovered path segment darker than remaining path
    • grey out other paths/nodes
  • less edges by default, so that view isn't crammed

How did you test this code?

@thmsobrmlr thmsobrmlr changed the base branch from master to sankey-refactor-1 February 5, 2025 14:03
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

8 snapshot changes in total. 0 added, 8 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@thmsobrmlr thmsobrmlr changed the title refactor(paths): clone sankey data to prevent mutations refactor(paths): improve paths visualization Feb 5, 2025
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Size Change: +5 B (0%)

Total Size: 1.17 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.17 MB +5 B (0%)

compressed-size-action

Base automatically changed from sankey-refactor-1 to master February 10, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants