chore: update taxomony with new property #28339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added $last_posthog_reset property to the taxonomy files to track the timestamp of the last web SDK Reset call, aligning documentation with functionality introduced in version 1.207.5.
- Added
$last_posthog_resettoevent_propertiesin/frontend/src/lib/taxonomy.tsxwith debugging description - Added corresponding property definition in
/posthog/taxonomy/taxonomy.pymarked as system property - Property marked to be ignored by AI assistant to avoid unnecessary surfacing in recommendations
2 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
posthog/taxonomy/taxonomy.py
Outdated
| @@ -272,6 +272,12 @@ class CoreFilterDefinition(TypedDict): | |||
| }, | |||
| }, | |||
| "event_properties": { | |||
| "$last_posthog_reset": { | |||
| "label": "Timestamp of last call to `Reset`in the web sdk", | |||
There was a problem hiding this comment.
syntax: Missing space between Reset and in in the label text
frontend/src/lib/taxonomy.tsx
Outdated
Comment on lines
272
to
273
| label: 'Timestamp of last call to `Reset`in the web sdk', | ||
| description: 'The timestamp of the last call to `Reset` in the web SDK. This can be useful for debugging.', |
There was a problem hiding this comment.
syntax: typo in 'Reset`in' - missing space
|
Size Change: +195 B (+0.02%) Total Size: 1.17 MB ℹ️ View Unchanged
|
pauldambra
commented
Feb 5, 2025
benHPostHog
approved these changes
Feb 5, 2025
pauldambra
commented
Feb 5, 2025
rafaeelaudibert
approved these changes
Feb 5, 2025
veryayskiy
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we added this in 1.207.5
but forgot to update the taxonomy