-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get CSV response #253
Get CSV response #253
Conversation
BTW, the build is failing because of some problem with a hasql package during |
This will be a nice feature! As for the test failure, try changing the version constraint in the cabal file to
I should make packdeps a warning rather than an error because it breaks unpredictably when people update other packages. |
I bumped the hasql-postgres version on master so when we merge this branch the packdeps will not complain. Just tried out your feature and it's working great (nice refactors inside too)! Only thing I noticed is that the response headers say |
Thanks man, I should be able to finish it in the next couple of days. |
Really looking forward to this, let me know if I can help with any testing! I'm looking at potentially using this for a data API that might at times be returning millions of rows, thus we're trying to avoid JSON. |
@begriffs sorry, I was still working out some issues here, I'm opening a new PR for that ;) |
And thanks for the neat mention in the README :D |
This is a draft, for I still need to make the accept headers work with text/csv + the API versioning.
But I'd like to get some early feedback on the code so far :D
This should fix issue #226