Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth: Use deb-conffiles mechanism to remove old conffiles #15053

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zeha
Copy link
Collaborator

@zeha zeha commented Jan 19, 2025

Short description

Switches Debian packaging for authoritative server from a custom preinst script to the dpkg-supported way of removing old conffiles. This feature is available since dpkg 1.20.6 (in Debian bullseye).

Might help Debian users with sysvinit.

I've put the same change into Debian's packaging, minus the Pre-Depends, as I don't expect Debian's packaging to be reused by anyone for EOL releases.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Available since dpkg 1.20.6 (in Debian bullseye).
@zeha
Copy link
Collaborator Author

zeha commented Jan 19, 2025

So it turns out, the official dpkg support for this is nothing better than our custom script:

Unpacking pdns-server (4.9.3-2) ...
Obsolete conffile '/etc/init.d/pdns' has been modified by you.
Saving as /etc/init.d/pdns.dpkg-old ...

@zeha
Copy link
Collaborator Author

zeha commented Jan 19, 2025

Depending on how far back you want to support upgrades, we could also just drop it altogether.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12856930539

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 31 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.01%) to 64.706%

Files with Coverage Reduction New Missed Lines %
pdns/recursordist/sortlist.cc 2 74.12%
pdns/backends/gsql/gsqlbackend.hh 2 97.71%
modules/lmdbbackend/lmdbbackend.cc 2 73.62%
pdns/packethandler.cc 3 72.44%
pdns/remote_logger.cc 3 53.81%
pdns/iputils.cc 3 56.07%
pdns/opensslsigners.cc 3 61.34%
pdns/recursordist/test-syncres_cc1.cc 13 89.41%
Totals Coverage Status
Change from base Build 12832418127: 0.01%
Covered Lines: 127803
Relevant Lines: 166436

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants