Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more clang-tidy fixups #15054

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

more clang-tidy fixups #15054

wants to merge 4 commits into from

Conversation

neheb
Copy link
Contributor

@neheb neheb commented Jan 20, 2025 •
edited
Loading

I have:

@neheb neheb force-pushed the bb branch 3 times, most recently from 6aed331 to 685e474 Compare January 20, 2025 03:01
@coveralls
Copy link

coveralls commented Jan 20, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12898414676

Details

  • 39 of 52 (75.0%) changed or added relevant lines in 20 files are covered.
  • 50 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.002%) to 64.695%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/dnsrecords.hh 3 4 75.0%
modules/geoipbackend/geoipinterface-dat.cc 0 2 0.0%
pdns/dnsdistdist/dnsdist-secpoll.cc 0 2 0.0%
pdns/lua-record.cc 0 3 0.0%
pdns/dnsdistdist/dnsdist-carbon.cc 3 8 37.5%
Files with Coverage Reduction New Missed Lines %
pdns/packethandler.cc 1 72.32%
modules/gpgsqlbackend/gpgsqlbackend.cc 1 88.62%
pdns/misc.cc 2 62.55%
pdns/remote_logger.cc 3 54.71%
pdns/iputils.cc 3 56.07%
pdns/recursordist/test-syncres_cc1.cc 5 89.45%
pdns/dnsdistdist/dnsdist-carbon.cc 9 61.6%
ext/json11/json11.cpp 12 62.72%
modules/lmdbbackend/lmdbbackend.cc 14 72.68%
Totals Coverage Status
Change from base Build 12884379895: -0.002%
Covered Lines: 127788
Relevant Lines: 166432
💛 - Coveralls

@rgacogne
Copy link
Member

I just merged #14954 and now this PR is conflicted, sorry!

@neheb neheb force-pushed the bb branch 5 times, most recently from e43db7f to d3aaede Compare January 21, 2025 01:02
neheb added 4 commits January 21, 2025 16:16
@neheb
clang-tidy: convert to range for loop
224fb70 
Found with modernize-loop-convert

Signed-off-by: Rosen Penev <[email protected]>
@neheb
boost::replace_all > std::replace
34ea1b9 
Signed-off-by: Rosen Penev <[email protected]>
@neheb
clang-tidy: use default member init
6c0f3bc 
Signed-off-by: Rosen Penev <[email protected]>
@neheb
clang-tidy: pass by value
f948cdd 
Signed-off-by: Rosen Penev <[email protected]>
rgacogne
rgacogne reviewed Jan 23, 2025
View reviewed changes
Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You changes look good to me, thanks a lot! I see clang-tidy is still unhappy about a few things, please let me know if you want me to fix these remaining nits, I would completely understand :)

@rgacogne rgacogne added this to the common-soon milestone Jan 23, 2025
@neheb
Copy link
Contributor Author

neheb commented Jan 24, 2025 •
edited
Loading

Sure, go ahead. The clang-tidy errors are not really related to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgacogne rgacogne rgacogne left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
auth dnsdist enhancement rec
Projects
None yet
Milestone
common-soon
Development

Successfully merging this pull request may close these issues.
3 participants
@neheb @coveralls @rgacogne