Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Enable the new YAML configuration in our packages #15065

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rgacogne
Copy link
Member

Short description

This PR switches the compiler from G++ to clang++ to keep building with LTO, which is not possible with g++ now that we link against a Rust-based static library built with LLVM.

Note that it breaks on EL-7 (no python yaml package) and Debian Buster (linking issue related to std::filesystem I haven't investigated yet). We might get away with not supporting DNSdist 2.0+ on these.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-2.0.0 milestone Jan 20, 2025
@coveralls
Copy link

coveralls commented Jan 20, 2025

Pull Request Test Coverage Report for Build 12873140486

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 164 unchanged lines in 13 files lost coverage.
  • Overall coverage increased (+0.009%) to 64.688%

Files with Coverage Reduction New Missed Lines %
pdns/packethandler.cc 1 72.35%
pdns/recursordist/aggressive_nsec.cc 2 66.02%
pdns/sstuff.hh 2 56.83%
pdns/recursordist/test-syncres_cc2.cc 3 88.85%
pdns/stubresolver.cc 3 77.58%
pdns/signingpipe.cc 5 83.91%
pdns/dnsparser.hh 6 78.53%
pdns/dnsdistdist/dnsdist-tcp.cc 8 75.79%
pdns/misc.cc 10 62.49%
pdns/dnsparser.cc 11 85.24%
Totals Coverage Status
Change from base Build 12869957002: 0.009%
Covered Lines: 127787
Relevant Lines: 166434

💛 - Coveralls

@rgacogne rgacogne force-pushed the ddist-enable-yaml-packages branch from 99cfb36 to 5b8539a Compare January 20, 2025 15:16
@Habbie
Copy link
Member

Habbie commented Jan 20, 2025

Note that it breaks on EL-7 (no python yaml package) and Debian Buster (linking issue related to std::filesystem I haven't investigated yet). We might get away with not supporting DNSdist 2.0+ on these.

#14990 (should finish it soon) will drop both. You definitely can ignore them (although we might want to merge 14990 before merging this)

@rgacogne
Copy link
Member Author

Copy link
Contributor

@miodvallat miodvallat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Probably the least horrible way to go.

builder-support/debian/dnsdist/debian-bookworm/rules Outdated Show resolved Hide resolved
So we can actually check later if they are still needed.
Copy link
Member

@romeroalx romeroalx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants