-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dnsdist: Enable the new YAML configuration in our packages #15065
base: master
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 12873140486Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
99cfb36
to
5b8539a
Compare
#14990 (should finish it soon) will drop both. You definitely can ignore them (although we might want to merge 14990 before merging this) |
Successful run in https://github.com/rgacogne/pdns/actions/runs/12871028684 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Probably the least horrible way to go.
So we can actually check later if they are still needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Test building images: https://github.com/romeroalx/pdns/actions/runs/12872083041
Short description
This PR switches the compiler from G++ to clang++ to keep building with LTO, which is not possible with g++ now that we link against a Rust-based static library built with LLVM.
Note that it breaks on EL-7 (no python yaml package) and Debian Buster (linking issue related to std::filesystem I haven't investigated yet). We might get away with not supporting DNSdist 2.0+ on these.
Checklist
I have: