-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch ubuntu-20.04 workflows to 24.04 #15143
Conversation
Anyone please feel free to look at whatever is red and see if you can help. Currently it looks like the clang-format config might want some changed defaults to be made more explicit. |
Default clang-format of noble seems to be clang-format-18, while the old one is 10 or 11, I'll take a look. |
…ing space Still some formatting differences, but they look legit. It seems older versions of clang-format did not process preprocessor conditionals correctly in all cases.
This should be green now. I committed the formatting changes, causing some churn, but oh well. If we accept a little bit more churn we could remove the For people runnnig |
I'm ignoring the clang-tidy warnings. |
Agreed. I'll force merge. |
Short description
100% untested, let's see
Checklist
I have: