Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch ubuntu-20.04 workflows to 24.04 #15143

Merged
merged 6 commits into from
Feb 13, 2025
Merged

Conversation

Habbie
Copy link
Member

@Habbie Habbie commented Feb 11, 2025

Short description

100% untested, let's see

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@Habbie
Copy link
Member Author

Habbie commented Feb 11, 2025

Anyone please feel free to look at whatever is red and see if you can help. Currently it looks like the clang-format config might want some changed defaults to be made more explicit.

@omoerbeek
Copy link
Member

omoerbeek commented Feb 12, 2025

Default clang-format of noble seems to be clang-format-18, while the old one is 10 or 11, I'll take a look.
I see now clang-19 is installed by the workflow, I have to check if that also updates clang-format to 19.

…ing space

Still some formatting differences, but they look legit. It seems
older versions of clang-format did not process preprocessor
conditionals correctly in all cases.
@omoerbeek
Copy link
Member

omoerbeek commented Feb 12, 2025

This should be green now. I committed the formatting changes, causing some churn, but oh well. If we accept a little bit more churn we could remove the .clang-format change in 6fb460aab83ccee1e00f713628040643b554dc79

For people runnnig clang-format locally: switch to clang-format-19 after this is merged to avoid surprises. In general the versions of clang-format agree, but differences between versions might pop up.

@omoerbeek
Copy link
Member

I'm ignoring the clang-tidy warnings.

@Habbie Habbie marked this pull request as ready for review February 13, 2025 09:47
@Habbie
Copy link
Member Author

Habbie commented Feb 13, 2025

I'm ignoring the clang-tidy warnings.

Agreed. I'll force merge.

@Habbie Habbie merged commit b43ff6f into PowerDNS:master Feb 13, 2025
82 of 83 checks passed
@Habbie Habbie deleted the no-ubuntu-20.04 branch February 13, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants