mod: move episode comments to menu #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
这个PR非常漂亮 但是按照我对 tab 行为的理解 这样会导致每次观看番剧时自动加载评论 我们能否修改为只在切换到评论选项卡时进行加载？ |
|
不会，它只会在切换过去的时候进行加载，然后 keep alive 直到 video_page 被 dispose |
|
切换分集后评论区加载会出问题 |
|
我看看怎么解决，我测试总是忘记切分集（） |
|
解耦和重构应该完成了 现在和 media_kit 直接耦合的部分已经限制在了 player_controller.dart 和 player_item_surface.dart 中, 外部目前也不再存在对 mediaPlayer 对象的直接引用 |
|
太好了。 另外切集这个问题有点麻烦，目前还没找到有效的解决办法，keep alive 造成的问题有点多 |
|
其实 keep alive 主要就是为了解决 tab 切换时的卡顿问题，虽说这个卡顿在 Release 模式下会缓解但我不确定在性能较差的设备上会不会出现卡顿。为什么 bottom sheet 就不会卡顿呢，不理解 |
|
Tab 就是很容易卡，在 flutter framework 层面的实现里也看不出什么。在组件树中维护所有 tabBody 可能是卡顿的原因？ 不然可以考虑做一个伪 tab 实现，不再维护所有 tabBody ，也不考虑 tab 过渡动画的实现问题 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复上一个 PR 的 Timer 问题
移动评论区，和选集放在一起。这样做的好处是比较整齐，后续有 bangumi 登录之后也可以增加发送评论的功能，会比较好看