Added states (countries, counties, cities, districts, boroughs) for UK #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nited Kindom gb.xml
Progi1984
approved these changes
Apr 25, 2022
|
I dont think this new list is complete, i took a quick glance and noticed it has Doncaster as a state when actually Doncaster is within South Yorkshire which wasnt present in the list. Need a better list, there is one on here: uk-counties/uk-counties-list.csv on git |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ticket PrestaShop/PrestaShop#19430 requests to add states to the United Kingdom.
I believe there are no states in the United Kingdom, but they have divisions (countries England, Scotland and Wales) and subdivisions (boroughs, cities, counties and districts). I am not from UK, but I added "states" based on the ISO 3166-2 (https://www.iso.org/obp/ui/#iso:code:3166:GB) which has the latest changes up to November 25, 2021.
This pull request is important to proceed adding the suggested taxes and taxes rules (in an upcoming PR).