Refactor Codebase to Use Symfony Filesystem Instead of Native PHP Functions #4815
M0rgan01php.yml
on: pull_request
PHP Syntax check 7.1 => 8.1
1m 5s
PHP-CS-Fixer
21s
PHP 5.6 Syntax Check
7s
Matrix: PHP Unit
Matrix: PHPStan
Annotations
43 errors and 9 warnings
|
PHP-CS-Fixer
Process completed with exit code 8.
|
|
PHPStan (1.7.3.4):
classes/Parameters/FileStorage.php#L50
Constructor of class PrestaShop\Module\AutoUpgrade\Parameters\FileStorage has an unused parameter $filesystem.
|
|
PHPStan (1.7.3.4):
classes/Services/ComposerService.php#L39
Property PrestaShop\Module\AutoUpgrade\Services\ComposerService::$filesystem is never read, only written.
|
|
PHPStan (1.7.3.4):
classes/Services/PrestashopVersionService.php#L22
Property PrestaShop\Module\AutoUpgrade\Services\PrestashopVersionService::$filesystem is never read, only written.
|
|
PHPStan (1.7.3.4):
classes/Task/Update/Download.php#L66
Call to an undefined static method PrestaShop\Module\AutoUpgrade\UpgradeTools\FilesystemAdapter::deleteDirectory().
|
|
PHPStan (1.7.3.4):
classes/Task/Update/Unzip.php#L60
Call to an undefined static method PrestaShop\Module\AutoUpgrade\UpgradeTools\FilesystemAdapter::deleteDirectory().
|
|
PHPStan (1.7.3.4):
classes/Task/Update/UpdateComplete.php#L71
Call to an undefined static method PrestaShop\Module\AutoUpgrade\UpgradeTools\FilesystemAdapter::deleteDirectory().
|
|
PHPStan (1.7.3.4):
classes/Task/Update/UpdateFiles.php#L184
Call to an undefined static method PrestaShop\Module\AutoUpgrade\UpgradeTools\FilesystemAdapter::deleteDirectory().
|
|
PHPStan (1.7.3.4):
classes/Task/Update/UpdateModules.php#L72
Class PrestaShop\Module\AutoUpgrade\UpgradeTools\Module\ModuleMigration constructor invoked with 3 parameters, 4 required.
|
|
PHPStan (1.7.3.4):
classes/Task/Update/UpdateModules.php#L72
Parameter #1 $filesystem of class PrestaShop\Module\AutoUpgrade\UpgradeTools\Module\ModuleMigration constructor expects Symfony\Component\Filesystem\Filesystem, PrestaShop\Module\AutoUpgrade\UpgradeTools\Translator given.
|
|
PHPStan (1.7.3.4):
classes/Task/Update/UpdateModules.php#L72
Parameter #2 $translator of class PrestaShop\Module\AutoUpgrade\UpgradeTools\Module\ModuleMigration constructor expects PrestaShop\Module\AutoUpgrade\UpgradeTools\Translator, PrestaShop\Module\AutoUpgrade\Log\Logger given.
|
|
PHPStan (1.7.2.5)
The job was canceled because "_1_7_3_4" failed.
|
|
PHPStan (1.7.2.5):
classes/Parameters/FileStorage.php#L50
Constructor of class PrestaShop\Module\AutoUpgrade\Parameters\FileStorage has an unused parameter $filesystem.
|
|
PHPStan (1.7.2.5):
classes/Services/ComposerService.php#L39
Property PrestaShop\Module\AutoUpgrade\Services\ComposerService::$filesystem is never read, only written.
|
|
PHPStan (1.7.2.5):
classes/Services/PrestashopVersionService.php#L22
Property PrestaShop\Module\AutoUpgrade\Services\PrestashopVersionService::$filesystem is never read, only written.
|
|
PHPStan (1.7.2.5):
classes/Task/Update/Download.php#L66
Call to an undefined static method PrestaShop\Module\AutoUpgrade\UpgradeTools\FilesystemAdapter::deleteDirectory().
|
|
PHPStan (1.7.2.5):
classes/Task/Update/Unzip.php#L60
Call to an undefined static method PrestaShop\Module\AutoUpgrade\UpgradeTools\FilesystemAdapter::deleteDirectory().
|
|
PHPStan (1.7.2.5):
classes/Task/Update/UpdateComplete.php#L71
Call to an undefined static method PrestaShop\Module\AutoUpgrade\UpgradeTools\FilesystemAdapter::deleteDirectory().
|
|
PHPStan (1.7.2.5):
classes/Task/Update/UpdateFiles.php#L184
Call to an undefined static method PrestaShop\Module\AutoUpgrade\UpgradeTools\FilesystemAdapter::deleteDirectory().
|
|
PHPStan (latest)
The job was canceled because "_1_7_3_4" failed.
|
|
PHPStan (1.7.2.5):
classes/Task/Update/UpdateModules.php#L72
Class PrestaShop\Module\AutoUpgrade\UpgradeTools\Module\ModuleMigration constructor invoked with 3 parameters, 4 required.
|
|
PHPStan (1.7.2.5):
classes/Task/Update/UpdateModules.php#L72
Parameter #1 $filesystem of class PrestaShop\Module\AutoUpgrade\UpgradeTools\Module\ModuleMigration constructor expects Symfony\Component\Filesystem\Filesystem, PrestaShop\Module\AutoUpgrade\UpgradeTools\Translator given.
|
|
PHPStan (1.7.2.5):
classes/Task/Update/UpdateModules.php#L72
Parameter #2 $translator of class PrestaShop\Module\AutoUpgrade\UpgradeTools\Module\ModuleMigration constructor expects PrestaShop\Module\AutoUpgrade\UpgradeTools\Translator, PrestaShop\Module\AutoUpgrade\Log\Logger given.
|
|
PHPStan (8.0.0)
The job was canceled because "_1_7_3_4" failed.
|
|
PHPStan (1.7.5.1)
The job was canceled because "_1_7_3_4" failed.
|
|
PHPStan (1.7.5.1):
classes/Parameters/FileStorage.php#L50
Constructor of class PrestaShop\Module\AutoUpgrade\Parameters\FileStorage has an unused parameter $filesystem.
|
|
PHPStan (1.7.5.1):
classes/Services/ComposerService.php#L39
Property PrestaShop\Module\AutoUpgrade\Services\ComposerService::$filesystem is never read, only written.
|
|
PHPStan (1.7.5.1):
classes/Services/PrestashopVersionService.php#L22
Property PrestaShop\Module\AutoUpgrade\Services\PrestashopVersionService::$filesystem is never read, only written.
|
|
PHPStan (1.7.5.1):
classes/Task/Update/Download.php#L66
Call to an undefined static method PrestaShop\Module\AutoUpgrade\UpgradeTools\FilesystemAdapter::deleteDirectory().
|
|
PHPStan (1.7.5.1):
classes/Task/Update/Unzip.php#L60
Call to an undefined static method PrestaShop\Module\AutoUpgrade\UpgradeTools\FilesystemAdapter::deleteDirectory().
|
|
PHPStan (1.7.5.1):
classes/Task/Update/UpdateComplete.php#L71
Call to an undefined static method PrestaShop\Module\AutoUpgrade\UpgradeTools\FilesystemAdapter::deleteDirectory().
|
|
PHPStan (1.7.5.1):
classes/Task/Update/UpdateFiles.php#L184
Call to an undefined static method PrestaShop\Module\AutoUpgrade\UpgradeTools\FilesystemAdapter::deleteDirectory().
|
|
PHPStan (1.7.5.1):
classes/Task/Update/UpdateModules.php#L72
Class PrestaShop\Module\AutoUpgrade\UpgradeTools\Module\ModuleMigration constructor invoked with 3 parameters, 4 required.
|
|
PHPStan (1.7.5.1):
classes/Task/Update/UpdateModules.php#L72
Parameter #1 $filesystem of class PrestaShop\Module\AutoUpgrade\UpgradeTools\Module\ModuleMigration constructor expects Symfony\Component\Filesystem\Filesystem, PrestaShop\Module\AutoUpgrade\UpgradeTools\Translator given.
|
|
PHPStan (1.7.5.1):
classes/Task/Update/UpdateModules.php#L72
Parameter #2 $translator of class PrestaShop\Module\AutoUpgrade\UpgradeTools\Module\ModuleMigration constructor expects PrestaShop\Module\AutoUpgrade\UpgradeTools\Translator, PrestaShop\Module\AutoUpgrade\Log\Logger given.
|
|
PHPStan (1.7.4.4)
The job was canceled because "_1_7_3_4" failed.
|
|
PHPStan (1.7.4.4)
The operation was canceled.
|
|
PHPStan (1.7.6)
The job was canceled because "_1_7_3_4" failed.
|
|
PHPStan (1.7.6)
The operation was canceled.
|
|
PHPStan (1.7.7)
The job was canceled because "_1_7_3_4" failed.
|
|
PHPStan (1.7.7)
The operation was canceled.
|
|
PHPStan (1.7.8)
The job was canceled because "_1_7_3_4" failed.
|
|
PHPStan (1.7.8)
The operation was canceled.
|
|
PHP-CS-Fixer
Your workflow is using a version of actions/cache that is scheduled for deprecation, actions/[email protected]. Please update your workflow to use either v3 or v4 of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down
|
|
PHP 5.6 Syntax Check
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
PHP-CS-Fixer
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
PHP Unit (7.2)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
PHP Unit (7.4)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
PHP Unit (8.1)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
PHP Unit (7.1)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
PHP Syntax check 7.1 => 8.1
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
PHPStan (1.7.3.4)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|