[NEW UI] Add restore choice dialogs #1108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ga-devfront
commented
Jan 8, 2025
•
ga-devfront
commented
| Questions | Answers |
|---|---|
| Description? | Add dialogs confirmation modals on restore backup choice page |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | N/A |
| Sponsor company | @PrestaShopCorp |
| How to test? | Try delete or restore a backup from restore backup choice page. |
ga-devfront
force-pushed
the
feat/add-restore-choice-modals
branch
from
2a9f11d to
f4add9e
Compare
M0rgan01
reviewed
Jan 10, 2025
| @@ -0,0 +1,34 @@ | |||
| import DomLifecycle from '../types/DomLifecycle'; | |||
There was a problem hiding this comment.
The question is a bit late, but why don't we also have the Header Stamp on the TS ? In the CORE project we have it https://github.com/PrestaShop/PrestaShop/blob/f4fab23ece8957b7dcf852f16bc49dd8c621aaac/js/admin/attachments.js#L1-L0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.