[NEW UI] clean old UI #1119
[NEW UI] clean old UI #1119
Conversation
ga-devfront
commented
Jan 15, 2025
•
ga-devfront
commented
| Questions | Answers |
|---|---|
| Description? | Clean all old files and function from old UI |
| Type? | refactor |
| BC breaks? | yes |
| Deprecations? | no |
| Fixed ticket? | N/A |
| Sponsor company | @PrestaShopCorp |
| How to test? | Try all process to be sure all work fine. |
ga-devfront
force-pushed
the
feat/clean-old-UI
branch
from
aec25d8 to
6792732
Compare
M0rgan01
force-pushed
the
feat/clean-old-UI
branch
6 times, most recently
from
a744240 to
e9861d0
Compare
classes/Workspace.php
Outdated
| { | ||
| $filePath = $directoryPath . DIRECTORY_SEPARATOR . 'index.php'; | ||
| if (!file_exists($filePath)) { | ||
| if (!copy(_PS_ROOT_DIR_ . DIRECTORY_SEPARATOR . 'config' . DIRECTORY_SEPARATOR . 'index.php', $filePath)) { |
There was a problem hiding this comment.
Shall we use Filesystem::copy here and let it handle the generation of IOException in case of error?
classes/Workspace.php
Outdated
| </IfModule> | ||
| HTACCESS; | ||
| if (!file_exists($filePath)) { | ||
| if (!file_put_contents($filePath, $content)) { |
There was a problem hiding this comment.
we use the method Filesystem::dumpFile and let it generate the IOException in case of error?
| @@ -311,13 +249,6 @@ public function init() | |||
| ); | |||
| } | |||
There was a problem hiding this comment.
This block can be removed, a comment has been added on #1117
M0rgan01
force-pushed
the
feat/clean-old-UI
branch
from
e9861d0 to
2e339d5
Compare
M0rgan01
force-pushed
the
feat/clean-old-UI
branch
from
2e339d5 to
7179ddb
Compare
M0rgan01
force-pushed
the
feat/clean-old-UI
branch
from
7179ddb to
1e18979
Compare
ga-devfront
force-pushed
the
feat/clean-old-UI
branch
from
1e18979 to
d97fa3c
Compare
…pgradeController.php
|
There was a problem hiding this comment.
Hi @ga-devfront
Thank you for your PR, I tested it and it seems to works as you can see :
recording.47.webm
Tested from :
1.7.8.8 to 8.2
8.0.4 to 8.2
8.2 to 9.0.0
8.0.4 to 9.0.0
Because the PR seems to works as expected, It's QA ✔️
Thank you
