-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tab, roles and feature flags related to new Admin API #686
base: dev
Are you sure you want to change the base?
Conversation
jolelievre
commented
Apr 2, 2024
Questions | Answers |
---|---|
Description? | Update tab, roles and feature flags related to new Admin API |
Type? | improvement |
BC breaks? | no |
Deprecations? | no |
Fixed ticket? | Fixes #{issue URL here}, Fixes #{another issue URL here} |
Sponsor company | ~ |
How to test? | ~ |
Hi @jolelievre Thank you for your PR, I tested it and : When I do an upgrade, I don't have the Api automatiquely checked like this PR add it : Except when I do it from a Multistore, the API button for Multistore is checked but not the Initial API, as you can see : recording.176.webmMoreover, When I do the Upgrade and I check the API Feature. I don't have the acces to it on BO as you can see on this screenshot Tested from When I do It from and when I clic on Authorization server, I have : Even if I enable "Admin API - Enable experimental endpoints" Do you know how to correct this things ? Waiting for feedback |
Thanks @AureRita I'll look into it, besides I have conflicts to fix anyway |
Is this PR still relevant @jolelievre ? |
@kpodemski I think it is, I'll check this tomorrow and update it if necessary |
Quality Gate passedIssues Measures |
Hi @jolelievre Thank you for your PR, I tested your PR again and it seems to have the same behaviour as you can see : recording.315.webmI didn't have the authorization server on the side. Waiting for your feedback |
Ping @jolelievre for rebase |