1179 - fixed "after a deal is funded, on page refresh, an error occurs" #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
IonelLupu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was done
Added a few rxjs streams that can be used to wait for some other parts of the app to load. As described below, some part of the app was running without waiting for the deals list to load.
This approach (with rxjs operators) can be used to remove the
waitUntilTruehack we have in Prime Deals and also removing the "race conditions" spread across the app.Testing
Before
looks like this occurs when:
you just started funding the deal. After aprox 5 min, this error goes away. This is because in the first 5 min, the contract data is taken from moduleContract.on. After 5 min, the contract data is take using moduleContract.queryFilter. The later makes the app not return any errors.
The underlying issue is that we are not waiting for the deals to load when we use moduleContract.on.
waitUntilTrue needs to be removed from Prime Deals. One solution is to use rxjs observables. (check the PR attached to this issue)
After