Sync #19
Merged
Sync #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4591) Uses ControlStructureTypes.CATCH, ControlStructureTypes.FINALLY, and ControlStructureTypes.ELSE now instead of relying on explicit order values.
…4597) Uses ControlStructureTypes.CATCH, ControlStructureTypes.FINALLY, and ControlStructureTypes.ELSE now instead of relying on explicit order values. Also add catch clause parameters (declarations) to their bodies content (which was missing entirely).
Methods require binding/ref edges with their corresponding type declaration in dynamic languages to correctly model their object-like behaviour. This PR implements these bindings following `pysrc2cpg`'s `createBinding` function. Additionally, adds the `CONSTRUCTOR` modifier to constructors. Resolves joernio#4593
…#4602) Uses ControlStructureTypes.CATCH and ControlStructureTypes.FINALLY now instead of relying on explicit order values.
…nio#4604) Uses ControlStructureTypes.CATCH and ControlStructureTypes.FINALLY now instead of relying on explicit order values.
Symbols are not parsed as operator expressions, so when they are given as a value to a named argument, they trigger an unhandled RubyNodeCreator case. This PR fixes that.
Uses ControlStructureTypes.CATCH and ControlStructureTypes.FINALLY now instead of relying on explicit order values.
This PR fixes previously unhandled call receivers, which creates an issue later during dynamic call linking as the receiver would be an Unknown node. * Handled quoted expanded regex literals * Handled constant variable references Additionally, this brings back warnings for `Unknown` nodes as these unhandled nodes are not syntax errors but don't necessarily have explicit warnings when unhandled.
…o#4609) Uses ControlStructureTypes.CATCH and ControlStructureTypes.FINALLY now instead of relying on explicit order values.
initial work to automate merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.