Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issues in HOME and BOOK-NOW page #1645

Closed
wants to merge 1 commit into from

Conversation

AADESHak007
Copy link
Contributor

@AADESHak007 AADESHak007 commented Oct 27, 2024

Related Issue

Fixes: #(1536)

Description

While i was fixing the errors somebody already completed the task so I looked for other errors in your repo and fixed them .
Issues I fixed are :

  • the visitor counter overlapping the language button
  • changed the color of the text in itineraries especially for dark-mode
  • fixed the UI of the BOOK now page .
  • handled the copyright in the BOOK now page

This PR fixes #1536 and will close it as completed .

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

BEFORE :
Screenshot 2024-10-27 091845
Screenshot 2024-10-27 091832
Screenshot 2024-10-27 091001
Screenshot 2024-10-27 085851

AFTER:
Screenshot 2024-10-27 093521
Screenshot 2024-10-27 092905
Screenshot 2024-10-27 092859
Screenshot 2024-10-27 094643
Screenshot 2024-10-27 094628

Checklist:

  • I have made this change from my own.
  • I have taken help from some online resources.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers and screenshots after making the changes.

Copy link

vercel bot commented Oct 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
buddy-trail ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2024 4:18am

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our contributing.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Oct 27, 2024

Deploy Preview for buddytrail ready!

Name Link
🔨 Latest commit 919c5b9
🔍 Latest deploy log https://app.netlify.com/sites/buddytrail/deploys/671dbf0071086c00088b2e52
😎 Deploy Preview https://deploy-preview-1645--buddytrail.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AADESHak007
Copy link
Contributor Author

@PriyaGhosal I was resolving errors but they were already resolved so I did some fixes in the same Issue .
I hope it doesn't cause you problem 'cause I was going to resolve them anyway.
Please validate this PR .

@PriyaGhosal
Copy link
Owner

@AADESHak007 Please see the conflicts . Resolve the conflicts . Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch. After resolving the conflicts, please open a new PR for review.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Some texts are not visible
2 participants