1587 add regularizer demo #1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kaibo <[email protected]>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Signed-off-by: kaibo <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: kaibo <[email protected]>
KumoLiu
reviewed
Dec 11, 2023
Signed-off-by: kaibo <[email protected]>
|
Hi @ebrahimebrahim, would you mind taking a look at this? I'm also wondering if I should mention your notebook somewhere in here. But anyways let me know what you think :) |
|
Yes, happy to look it over! Can someone add me as a reviewer? I will try to look at it this week. No need to mention the earlier notebook I think. One thing you could do is to add to the body of the commit message that says add regularizer demo |
|
@kvttt Added my suggestions. It looks great; thank you for putting this together!! I really like the separation between unequal and equal scaling of images. Everything is very clear and nicely organized. |
Co-authored-by: Ebrahim Ebrahim <[email protected]> Signed-off-by: kaibo <[email protected]>
Co-authored-by: Ebrahim Ebrahim <[email protected]> Signed-off-by: kaibo <[email protected]>
KumoLiu
approved these changes
Dec 27, 2023
boneseva
pushed a commit
to boneseva/MONAI-tutorials
that referenced
this pull request
Apr 21, 2024
Fixes Project-MONAI#1587. ### Description As mentioned in Project-MONAI#1587, the notebook should contain - [x] Formula for bending energy and diffusion, - [x] Demonstration that bending energy is not scale invariant while diffusion is not scale invariant in some cases (maybe display examples of these cases), and - [x] How both losses are made invariant by specifying `normalize=True`. ### Checks <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Avoid including large-size files in the PR. - [x] Clean up long text outputs from code cells in the notebook. - [x] For security purposes, please check the contents and remove any sensitive info such as user names and private key. - [ ] Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the `./figure` folder - [x] Notebook runs automatically `./runner.sh -t <path to .ipynb file>` --------- Signed-off-by: kaibo <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Ebrahim Ebrahim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1587.
Description
As mentioned in #1587, the notebook should contain
normalize=True.Checks
./figurefolder./runner.sh -t <path to .ipynb file>