Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug varautoencoder_mednist.ipynb #1626

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

clead6
Copy link
Contributor

@clead6 clead6 commented Jan 31, 2024

Bug in VAE tutorial, indexing of the data dictionaries train_datadict[:10] and test_datadict[:10] had been left there.

Description

In a previous commit, someone left indexes on the data dictionaries train_datadict[:10] and test_datadict[:10] to debug. I removed them so the code properly runs on the whole dataset.

Checks

Bug in VAE tutorial, indexing of the data dictionaries train_datadict[:10] and test_datadict[:10] had been left there.

Signed-off-by: Clea Dronne <[email protected]>
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.

@KumoLiu KumoLiu enabled auto-merge (squash) February 1, 2024 02:47
@KumoLiu KumoLiu merged commit 3093dec into Project-MONAI:main Feb 1, 2024
6 checks passed
@clead6 clead6 deleted the fix_vae_tutorial branch February 1, 2024 09:11
@Sembelawi
Copy link

modules/engines/unet_training_dict.py

I am currently using the above tutorial for supervised training. Unfortunately, the early stopping handler is triggered right at the beginning. I am receiving the following below feedback and I could not identify where the bug is. Thanks in progress!

2024-02-03 10:44:10,219 ignite.handlers.early_stopping.EarlyStopping INFO: EarlyStopping: Stop training
2024-02-03 10:44:10,220 - INFO - Epoch: 1/100, Iter: 21/3264 -- train_loss: 1.0000

@KumoLiu
Copy link
Contributor

KumoLiu commented Feb 5, 2024

Hi @Sembelawi, the reason is that your loss didn't decrease after the patience. You can either set up larger patience or check your data.
https://github.com/Project-MONAI/MONAI/blob/33afaefff925dce45b8331e8290f234a4d95fd51/monai/handlers/earlystop_handler.py#L37

boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
Bug in VAE tutorial, indexing of the data dictionaries
train_datadict[:10] and test_datadict[:10] had been left there.

### Description
In a previous commit, someone left indexes on the data dictionaries
train_datadict[:10] and test_datadict[:10] to debug. I removed them so
the code properly runs on the whole dataset.

### Checks

Signed-off-by: Clea Dronne <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants