Update to use torchrun in "brats_training_ddp" #1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: YunLiu <[email protected]>
| --nnodes=NUM_NODES --node_rank=INDEX_CURRENT_NODE | ||
| --master_addr="localhost" --master_port=1234 | ||
| brats_training_ddp.py -d DIR_OF_TESTDATA | ||
| python -m torchrun --nproc_per_node=NUM_GPUS_PER_NODE --nnodes=NUM_NODES |
There was a problem hiding this comment.
No "python -m " here.
| `--master_addr="localhost"` | ||
| `--master_port=1234` | ||
| For more details, refer to https://github.com/pytorch/pytorch/blob/master/torch/distributed/launch.py. | ||
| For more details, refer to https://github.com/pytorch/pytorch/blob/master/torch/distributed/run.py. |
There was a problem hiding this comment.
The correct link is as follows.
https://github.com/pytorch/pytorch/blob/main/torch/distributed/run.py
KumoLiu
added a commit
to KumoLiu/tutorials
that referenced
this pull request
Mar 26, 2024
Signed-off-by: YunLiu <[email protected]>
5 tasks
KumoLiu
added a commit
that referenced
this pull request
Mar 27, 2024
Address comments in #1666 ### Checks <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [ ] Avoid including large-size files in the PR. - [ ] Clean up long text outputs from code cells in the notebook. - [ ] For security purposes, please check the contents and remove any sensitive info such as user names and private key. - [ ] Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the `./figure` folder - [ ] Notebook runs automatically `./runner.sh -t <path to .ipynb file>` Signed-off-by: YunLiu <[email protected]>
boneseva
pushed a commit
to boneseva/MONAI-tutorials
that referenced
this pull request
Apr 21, 2024
Fixes Project-MONAI#1665 ### Checks <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [ ] Avoid including large-size files in the PR. - [ ] Clean up long text outputs from code cells in the notebook. - [ ] For security purposes, please check the contents and remove any sensitive info such as user names and private key. - [ ] Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the `./figure` folder - [ ] Notebook runs automatically `./runner.sh -t <path to .ipynb file>` --------- Signed-off-by: YunLiu <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boneseva
pushed a commit
to boneseva/MONAI-tutorials
that referenced
this pull request
Apr 21, 2024
Address comments in Project-MONAI#1666 ### Checks <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [ ] Avoid including large-size files in the PR. - [ ] Clean up long text outputs from code cells in the notebook. - [ ] For security purposes, please check the contents and remove any sensitive info such as user names and private key. - [ ] Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the `./figure` folder - [ ] Notebook runs automatically `./runner.sh -t <path to .ipynb file>` Signed-off-by: YunLiu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1665
Checks
./figurefolder./runner.sh -t <path to .ipynb file>