Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix maisi diffusion net single gpu training issue #1851

Merged
merged 6 commits into from
Sep 30, 2024

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Sep 30, 2024

Fix maisi diffusion net single gpu training issue

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@mingxin-zheng mingxin-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KumoLiu . The change looks good to me.

If you have a chance, can you also update the type hint (int) in here:

def initialize_distributed(num_gpus) -> tuple:

@KumoLiu
Copy link
Contributor Author

KumoLiu commented Sep 30, 2024

Hi @dongyang0122, @guopengf and @Can-Zhao, I will merge this PR for qa test first. If you have any further comments, we can update it in the later PRs, thanks.

@KumoLiu KumoLiu enabled auto-merge (squash) September 30, 2024 07:33
@KumoLiu KumoLiu merged commit 071eb1a into Project-MONAI:main Sep 30, 2024
6 checks passed
@KumoLiu KumoLiu deleted the fix-maisi branch September 30, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants