Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update max_epochs to be int #1878

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Update max_epochs to be int #1878

merged 1 commit into from
Nov 15, 2024

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Nov 15, 2024

Fix max_epochs not correctly update in this tutorial:
https://github.com/Project-MONAI/tutorials/blob/main/generation/anomaly_detection/2d_classifierfree_guidance_anomalydetection_tutorial.ipynb?short_path=1f8100f#L429

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

@KumoLiu KumoLiu requested review from ericspod and Nic-Ma November 15, 2024 08:33
@ericspod
Copy link
Member

I think max_epoch should always be an integer, the example you cite here should be fixed to be 20000 instead I feel.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@KumoLiu
Copy link
Contributor Author

KumoLiu commented Nov 15, 2024

I think max_epoch should always be an integer, the example you cite here should be fixed to be 20000 instead I feel.

Sure, open to this issue. Update based on your comments.

@KumoLiu KumoLiu changed the title Modify the max epoch update rules to support regular expressions Update max_epochs to be int Nov 15, 2024
@ericspod
Copy link
Member

I think max_epoch should always be an integer, the example you cite here should be fixed to be 20000 instead I feel.

Sure, open to this issue. Update based on your comments.

Looks good thanks, though I see the generated content of cells is now missing. I think it would be fine to revert the notebook and re-apply your change (and add the missing title) without rerunning the notebook.

Signed-off-by: YunLiu <[email protected]>
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Nov 15, 2024

Looks good thanks, though I see the generated content of cells is now missing. I think it would be fine to revert the notebook and re-apply your change (and add the missing title) without rerunning the notebook.

It's wired, actually I didn't rerun the notebook. But anyway I updated it. Thanks!

@KumoLiu KumoLiu merged commit 1c784e0 into Project-MONAI:main Nov 15, 2024
6 checks passed
@KumoLiu KumoLiu deleted the fix-ci branch November 15, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants