Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jupyter_server version pin #7

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Remove jupyter_server version pin #7

merged 2 commits into from
Jun 30, 2023

Conversation

brian-rose
Copy link
Member

This cookbook is encountering some build problems on the binder

Removing this obsolete version pin might help.

@github-actions
Copy link

github-actions bot commented Jun 29, 2023

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 6999bf0
✅ Deployment Preview URL: In Progress

@brian-rose
Copy link
Member Author

We just got a notice that Jetstream2 (which runs the Pythia binder) is down today. That probably explains the current failure. I'll trigger this again later once JS2 is back online.

@brian-rose
Copy link
Member Author

So it turns out this is actually failing because of a bug in our workflows that I just discovered (ProjectPythia/cookbook-actions#79) that affects some PRs that include a change in the environment file.

I will merge this change since it brings this cookbook's environment up to date with the latest template. If there are any further problems with the build (aside from the expected link check failure) we'll figure those out before making a first release of this Cookbook.

@brian-rose brian-rose marked this pull request as ready for review June 30, 2023 02:48
@brian-rose
Copy link
Member Author

Just noticed that the changed line may have a typo?

Yep I caught that too! Just pushed a fix. Thanks!

@brian-rose brian-rose merged commit 681b6f8 into main Jun 30, 2023
@brian-rose brian-rose deleted the brian-rose-patch-4 branch June 30, 2023 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant