Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neighborhood hover not working on our maps in Firefox #3777 #3796

Merged
merged 5 commits into from
Feb 13, 2025

Conversation

heonjwa
Copy link
Collaborator

@heonjwa heonjwa commented Feb 8, 2025

Resolves #3777

Configured tooltopTimout variable to handle flickering on toolbox when hovered by adding slight delay when removing tool tip which gives the user time to move their mouse onto the tooltip.

Before/After screenshots (if applicable)
before.mp4
after.mp4
Testing instructions
  1. Open up firefox and hover over label map and check whether there is flickering.
Things to check before submitting the PR
  • I've written a descriptive PR title.
  • I've added/updated comments for large or confusing blocks of code.
  • I've included before/after screenshots above.
  • I've asked for and included translations for any user facing text that was added or modified.
  • I've updated any logging. Clicks, keyboard presses, and other user interactions should be logged. If you're not sure how (or if you need to update the logging), ask Mikey. Then make sure the documentation on this wiki page is up to date for the logs you added/updated.
  • I've tested on mobile (only needed for validation page).

Copy link
Member

@misaugstad misaugstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working nicely! I tested on Chrome and Firefox for now. Are you using a Mac? If so, have you checked that it's working on Safari as well?

I also added a couple of comments throughout the code to address. Nothing major!

public/javascripts/PSMap/AddNeighborhoodsToMap.js Outdated Show resolved Hide resolved
public/javascripts/PSMap/AddNeighborhoodsToMap.js Outdated Show resolved Hide resolved
public/javascripts/PSMap/AddNeighborhoodsToMap.js Outdated Show resolved Hide resolved
@misaugstad
Copy link
Member

And make sure to pull in most recent changes to develop! You were behind by 25 commits or so, but I pulled in changes while I was testing this time!

@heonjwa
Copy link
Collaborator Author

heonjwa commented Feb 11, 2025

Works on Safari!

@heonjwa
Copy link
Collaborator Author

heonjwa commented Feb 11, 2025

Updated the changes you mentioned and committed

Copy link
Member

@misaugstad misaugstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now, thanks for the fix!

@misaugstad misaugstad merged commit 02b299a into develop Feb 13, 2025
@misaugstad misaugstad deleted the 3777-neighborhood-hover branch February 13, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Neighborhood hover not working on our maps in Firefox
2 participants