-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TJLF-EP #12
Open
orso82
wants to merge
20
commits into
master
Choose a base branch
from
tjlfep
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's my bad, I instigated Ben to push his work and forgot that TJLF is already part of the larger machinery since Jan 30th |
No worries @tomneiser and @benja0525 . This is what |
… a specific case); consistency with nmodes_out
…ferent L_QL_RATIO flag tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@benja0525 please do your developments on the
tjlfep
branch.Before making changes in
master
we must make sure that they do not break the original functionality of TJFL, since that has repercussions elsewhere. I have now protected themaster
branch.Keep it up with the great work, and let me or @tomneiser know when you are ready for a code-review, so that we can trigger the regression tests and make sure that everything works with your developments as intended.