Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a format argument to extract_fin_year() #122

Closed
wants to merge 2 commits into from

Conversation

Moohan
Copy link
Member

@Moohan Moohan commented Nov 24, 2023

This argument keeps the default format (so existing code will work without modification) and allows for choosing a numeric (integer) output.

I would find this useful, as I've been needing to do exactly this recently, not sure if we want to add it to this function though, so I've opened it as a draft.

If you think it's a worthwhile inclusion (and in this function), then I still need to:

  • Add some tests.
  • Properly update the documentation.

This argument keeps the default format (so existing code will work without modification) and allows for choosing a numeric (integer) output.
@Moohan Moohan requested a review from Tina815 November 24, 2023 11:30
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (106aaa6) 97.40% compared to head (b9d8bd2) 96.96%.
Report is 3 commits behind head on dev.

Files Patch % Lines
R/extract_fin_year.R 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #122      +/-   ##
==========================================
- Coverage   97.40%   96.96%   -0.44%     
==========================================
  Files          13       13              
  Lines         424      429       +5     
==========================================
+ Hits          413      416       +3     
- Misses         11       13       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Moohan Moohan added the enhancement New feature or request label Nov 24, 2023
@Tina815
Copy link
Contributor

Tina815 commented Nov 27, 2023

We can leave this and still keep the current function as it is for now.

@Tina815 Tina815 closed this Nov 27, 2023
@Tina815 Tina815 deleted the extract_fin_year_format branch November 27, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants