Separate chunk saving #470
Open
+929
−844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't link the abstraction you made, You just put in 4 different types into |
Snowiiii
reviewed
Jan 23, 2025
suprohub
force-pushed
the
chunk-saving-separator
branch
from
4996784 to
5bcb5ad
Compare
Snowiiii
reviewed
Jan 26, 2025
| } | ||
| } | ||
|
|
||
| /*#[cfg(test)] |
There was a problem hiding this comment.
Why you commented out the test
There was a problem hiding this comment.
Idk.
Maybe because i waited opinions, amd forgor fix test
There was a problem hiding this comment.
You can uncomment it. Or i can fix it when can
|
Looks like you just copy pasted the anvil implementation into InformativeTable. Also we should use Anvil as default |
Yeah, but like.. How i can name it?? "Anvil raw saving implementation?" |
|
And also we use anvil by default |
Snowiiii
reviewed
Jan 28, 2025
Snowiiii
reviewed
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WHat??? what the separation? u sily?
..
No.
My idea its separate chunk reading and writing. I want make 2 steps.
First we serialize a chunk in bytes. Its can be a simple vanilla anvil serialization.
Second we need write chunk to disk.
But how? Mojang for java now uses a location table. its a simple approach and not very good.
Will be cool add a db like in bedrock, or some other solutions. And also will be cool to use custom more optimized format.
But what, if server owner wants very fast chunk saving and not prioritizes space on disk what chunks are consuming? Or if owner wants another solution - dont waste disk space and have slow chunk saving? Or he wants a better vanilla compalibitle but want fast chunk access?
So, for all these questions i make solution - separated chunks.
Now its looks like this (example) :
db:
format:
Also its not a final version, and i want to discuss with us. And yeah, plugins can also make impls simplier, because for plugins dont need to be recreate location table functions.
Testing
cargo runsee inital works, see errors in console
see whats all savings and chunks working
Please follow our Coding Guidelines