Adds support for slabs and stairs #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So whats next @KairuDeibisu. Please use a better PR description than this |
KairuDeibisu
changed the title
KairuDeibisu
changed the title
KairuDeibisu
changed the title
KairuDeibisu
changed the title
I've updated it. |
KairuDeibisu
changed the title
|
I wonder if this supports properties which are loaded directly from anvil, and also the other way. So is this saved properly ? |
Snowiiii
reviewed
Jan 26, 2025
| @@ -1 +1,9 @@ | |||
| pub mod entity_registry; | |||
|
|
|||
| #[derive(Debug, PartialEq, Clone, Copy)] | |||
| pub enum FacingDirection { | |||
There was a problem hiding this comment.
This is already defined in pumpkin-world/block/mod
as BlockFace. We may want to rename that to Direction in place it in pumpkin-util/math
3 tasks
|
Thank you @KairuDeibisu and @Bafran |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge adds support for slabs and stairs.
The framework was made by @Bafran and expanded to support stairs.
Levers can be added in a latter pull request. For now, I want to get in the basics.
Untitled.video.7.1.mp4