Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin rewrite #513

Merged
merged 27 commits into from
Feb 1, 2025
Merged

Plugin rewrite #513

merged 27 commits into from
Feb 1, 2025

Conversation

suprohub
Copy link
Contributor

@suprohub suprohub commented Jan 29, 2025

Description

I added new events, converted event to derive macro.
Ajusted docs,
Created macro for sending cancellable events, also now used arc in context functions for registering handlers (may be useful when one struct have more what one event implementations).
Cargo.toml now not uses patch version, because its useless and like all crates adds not brraking updates to patch version.

Testing

clippy & fmt
Please follow our Coding Guidelines

suprohub and others added 16 commits January 28, 2025 22:23
fmt

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
fix

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
suprohub and others added 8 commits January 30, 2025 15:57

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…into plugin-rewrite
@Snowiiii
Copy link
Member

Snowiiii commented Feb 1, 2025

Remove "maked configurable value of capacity of player packets buffer (its useful).". Has nothing to do with Plugins.
Also for the 3th time now. Can you explain what these Logger implementations are and if there was any testing ?

@suprohub
Copy link
Contributor Author

suprohub commented Feb 1, 2025

Remove "maked configurable value of capacity of player packets buffer (its useful).". Has nothing to do with Plugins.
Also for the 3th time now. Can you explain what these Logger implementations are and if there was any testing ?

Ok, i remove commit.
Logger implementation its has, i also tested it, but it have 2 not breaking bugs.
First its prints like $[pumpkin@?] because of rustyline. How fix? Idk.
Next its a ? After @. Its show unknown thread.

@suprohub
Copy link
Contributor Author

suprohub commented Feb 1, 2025

Oh stop

@suprohub
Copy link
Contributor Author

suprohub commented Feb 1, 2025

No, second works correctly, ? Shows only in on_load func

@suprohub
Copy link
Contributor Author

suprohub commented Feb 1, 2025

Looks like this
2025-02-01-18-03-34-505.jpg

@suprohub
Copy link
Contributor Author

suprohub commented Feb 1, 2025

@Snowiiii i created static what contains dyn Log and created macro for automatization
log::set_logger(LOGGER)

Snowiiii and others added 2 commits February 1, 2025 16:58

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
fmt
@Snowiiii
Copy link
Member

Snowiiii commented Feb 1, 2025

Looks good, Thank you @suprohub 👍

@Snowiiii Snowiiii merged commit 186e846 into Pumpkin-MC:master Feb 1, 2025
9 checks passed
urisinger pushed a commit to urisinger/Pumpkin that referenced this pull request Feb 16, 2025
* simplify all

* fmt

* Consider using derive macro

* Add new events

* Add events call

* minor fixes

* minor fixes

* fix

* optimize code

* big changes

* fix skill issue

* fix

* Consider not specify patch version

* make logger shared

* i want test one thing

* Add one useful function

* add little amouth of docs

* use config instead

* revert changes

* fmt

---------

Co-authored-by: Alexander Medvedev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants