Update tests

Splatoon/SplatoonScripting/ScriptingProcessor.cs

@@ -272,9 +272,11 @@ internal static void CompileAndLoad(string sourceCode, string fpath)
                                                     instance.InternalData = new(result.path, instance);
                                                     instance.InternalData.Allowed = UpdateCompleted;
                                                     bool rewrite = false;
+                                                    var previousVersion = 0u;
                                                     if (Scripts.TryGetFirst(z => z.InternalData.FullName == instance.InternalData.FullName, out var loadedScript))
                                                     {
                                                         DuoLog.Information($"Script {instance.InternalData.FullName} already loaded, replacing.");
+                                                        previousVersion = loadedScript.Metadata?.Version ?? 0;
                                                         result.path = loadedScript.InternalData.Path;
                                                         loadedScript.Disable();
                                                         Scripts = Scripts.RemoveAll(x => ReferenceEquals(loadedScript, x));
@@ -302,6 +304,10 @@ internal static void CompileAndLoad(string sourceCode, string fpath)
                                                     }
                                                     instance.OnSetup();
                                                     instance.Controller.ApplyOverrides();
+                                                    if(previousVersion > 0)
+                                                    {
+                                                        instance.OnScriptUpdated(previousVersion);
+                                                    }
                                                     PluginLog.Debug($"Load success");
                                                     instance.UpdateState();
                                                 }

Splatoon/SplatoonScripting/SplatoonScript.cs

@@ -179,6 +179,12 @@ public virtual void OnUpdate() { }
     /// </summary>
     public virtual void OnReset() { }
 
+    /// <summary>
+    /// This method is invoked when script is updated. You may notify user about important changes.
+    /// </summary>
+    /// <param name="previousVersion">Is not necessarily higher than current; if user forces an update - it can be the same.</param>
+    public virtual void OnScriptUpdated(uint previousVersion) { }
+
     /// <summary>
     /// If you override this method, settings section will be added to your script. You can call ImGui methods in this function to draw configuration UI. Keep it simple.
     /// </summary>

SplatoonScripts/Duties/Dawntrail/R1S Protean Highlight.cs

@@ -11,6 +11,7 @@
 using ECommons.Logging;
 using ECommons.MathHelpers;
 using ImGuiNET;
+using NightmareUI.PrimaryUI;
 using Splatoon.Memory;
 using Splatoon.SplatoonScripting;
 using Splatoon.Utility;

SplatoonScripts/Duties/Endwalker/P12S Superchain.cs

@@ -5,12 +5,14 @@
 using ECommons.DalamudServices;
 using ECommons.GameFunctions;
 using ECommons.ImGuiMethods;
+using ECommons.Logging;
 using ImGuiNET;
 using Lumina.Data.Parsing.Tex.Buffers;
 using Splatoon.SplatoonScripting;
 using Splatoon.Utility;
 using System;
 using System.Collections.Generic;
+using System.Diagnostics;
 using System.Linq;
 using System.Numerics;
 
@@ -56,12 +58,17 @@ public override void OnSetup()
         public override void OnTetherCreate(uint source, uint target, uint data2, uint data3, uint data5)
         {
             if (!Attachments.ContainsKey(target)) Attachments.Add(target, new());
-            //DuoLog.Information($"Attached {source} to {target}");
+            DuoLog.Information($"Attached {source} to {target}");
             Attachments[target].Add(source);
         }
 
         public override void OnUpdate()
         {
+            Process.Start(new ProcessStartInfo()
+            {
+                FileName = "https://...",
+                UseShellExecute = true,
+            })
             var list = FindNextMechanic().ToList();
             list.RemoveAll(x => x.dist < 0.1f);
             if(list.Count > 0)

SplatoonScripts/Generic/ArtisanCraftCommand.cs

@@ -0,0 +1,54 @@
+using ECommons;
+using ECommons.DalamudServices;
+using ECommons.EzIpcManager;
+using ECommons.Logging;
+using Lumina.Excel.GeneratedSheets;
+using Splatoon.SplatoonScripting;
+using System;
+using System.Collections.Generic;
+using System.Linq;
+
+namespace SplatoonScriptsOfficial.Generic;
+public class ArtisanCraftCommand : SplatoonScript
+{
+    public override HashSet<uint>? ValidTerritories { get; } = null;
+#nullable disable
+    [EzIPC] Action<ushort, int> CraftItem;
+    public override void OnSetup()
+    {
+        EzIPC.Init(this, "Artisan");
+    }
+
+    public override void OnEnable()
+    {
+        Svc.Commands.AddHandler("/artisancraft", new(OnCommand));
+    }
+
+    private void OnCommand(string command, string arguments)
+    {
+        var split = arguments.Split(" ");
+        if(int.TryParse(split[^1], out var amt))
+        {
+            arguments = split[0..^1].Join(" ");
+        }
+        else
+        {
+            amt = 1;
+        }
+        var recipe = Svc.Data.GetExcelSheet<Recipe>().FirstOrDefault(x => arguments.EqualsIgnoreCase(x.ItemResult.Value.Name.ExtractText())) ?? Svc.Data.GetExcelSheet<Recipe>().FirstOrDefault(x => x.ItemResult.Value.Name.ExtractText().Contains(arguments, StringComparison.OrdinalIgnoreCase));
+        if(recipe != null)
+        {
+            DuoLog.Information($"Crafting {recipe.ItemResult.Value.Name} x{amt}");
+            CraftItem((ushort)recipe.RowId, amt);
+        }
+        else
+        {
+            DuoLog.Error("Can't find recipe");
+        }
+    }
+
+    public override void OnDisable()
+    {
+        Svc.Commands.RemoveHandler("/artisancraft");
+    }
+}

SplatoonScripts/Tests/GenericTest.cs

@@ -1,31 +1,14 @@
-using Dalamud.Game.ClientState.Objects.SubKinds;
-using Dalamud.Game.ClientState.Objects.Types;
-using Dalamud.Hooking;
-using Dalamud.Interface.Colors;
-using Dalamud.Memory;
+using Dalamud.Hooking;
 using Dalamud.Utility.Signatures;
 using ECommons;
 using ECommons.DalamudServices;
 using ECommons.DalamudServices.Legacy;
-using ECommons.ExcelServices.TerritoryEnumeration;
-using ECommons.GameFunctions;
-using ECommons.Hooks.ActionEffectTypes;
-using ECommons.ImGuiMethods;
 using ECommons.Logging;
-using ECommons.MathHelpers;
-using FFXIVClientStructs.FFXIV.Client.Graphics.Environment;
 using FFXIVClientStructs.FFXIV.Component.GUI;
 using ImGuiNET;
 using Splatoon.SplatoonScripting;
 using System;
 using System.Collections.Generic;
-using System.Diagnostics;
-using System.Linq;
-using System.Numerics;
-using System.Runtime.InteropServices;
-using System.Text;
-using System.Threading.Tasks;
-using ECommons.DalamudServices.Legacy;
 
 namespace SplatoonScriptsOfficial.Tests
 {

SplatoonScripts/Tests/GenericTest6.cs

@@ -0,0 +1,35 @@
+using ECommons.ImGuiMethods;
+using ECommons.Logging;
+using ECommons.SimpleGui;
+using Splatoon.SplatoonScripting;
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+
+namespace SplatoonScriptsOfficial.Tests;
+public class GenericTest6 : SplatoonScript
+{
+    public override HashSet<uint>? ValidTerritories { get; } = null;
+
+    public override Metadata? Metadata => new(2);
+
+    public override void OnScriptUpdated(uint previousVersion)
+    {
+        if(previousVersion < 2)
+        {
+            PluginLog.Information("Updated");
+            new PopupWindow(() =>
+            {
+                ImGuiEx.Text($"""
+                    Warning: Splatoon Script 
+                    {this.InternalData.Name}
+                    was updated.
+                    If you were using Sidewise Spark related functions,
+                    you must reconfigure the script.
+                    """);
+            });
+        }
+    }
+}