[VPRPVP] Emergency features / Snake Scales Fix. MCHPVP quickfix. #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
edewen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added The buff from snake scales to the list of when to ignore the emergency features. Basically, Snake scales is active and none of those buttons can be pressed until you backlash to end it, or it ends on its own. The features were preventing you from backlashing to end it.
Added Slither to the ignored movement action ids as well because I'm good like that.
Jr pvp dev when?
Added target check to mch pvp burst as a quick fix Tauren mentioned. It encompasses all of the burst mode instead of the couple lines he already added so it wont use analysis without a target and potentially waste the buffed tool attack.
Removed blazing shot option while I was at it, the game inherently changes the burst shot to blazing shot. You don't have a choice. Even with the option off, it does it because of the game itself. The option served no purpose.