Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds intro ltk lesson #368

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

adds intro ltk lesson #368

wants to merge 1 commit into from

Conversation

abadoni5
Copy link
Contributor

Summary

(short description of what does this PR, Issue #, etc.)

Checklist

  • Variables, functions and comments are translated to Spanish
  • Functions follow underscore notation
  • Spell check done & typos fixed
  • All python code is PEP8 compliant
  • Test coverage with Playwright implemented; locators are Pyhton code
  • Reviewers assigned (all peers & at least 1 mentor)

Screenshots

(prefer Playwright recorded video or animated gif)

Copy link

Copy link
Member

@reingart reingart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.. raw:: html

<div style="display: flex; justify-content: center; align-items: center; height: 100vh;">
<iframe src="/_static/ltk_mini_editor/ltk.html" width="100%" height="600px" frameborder="0"></iframe>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here you should remove the / as probably it is causing that the inner page cannot be loaded in a real webservice:
image

Probably this works in localhost, but we need to be able to serve with a random prefix.
See this lesson for an example to use a relative path:
https://github.com/PyAr/PyZombis/blob/main/_sources/lectures/TWP05/TWP05_3.rst?plain=1#L45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants