Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade action deps #421

Merged
merged 1 commit into from
Dec 21, 2023
Merged

chore: upgrade action deps #421

merged 1 commit into from
Dec 21, 2023

Conversation

chenrui333
Copy link
Contributor

@chenrui333 chenrui333 commented Nov 23, 2023 •
edited
Loading

  • upgrade actions to base on nodejs 20 runtime

facundobatista
facundobatista reviewed Nov 24, 2023
View reviewed changes
.github/workflows/tests.yaml
- name: Checkout code
uses: actions/checkout@v2
with:
fetch-depth: 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thanks for this! Question, why the removal of fetch-depth? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the fetch-depth would just do the HEAD build, would it disrupt anything?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see

facundobatista
facundobatista approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@facundobatista facundobatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

.github/workflows/tests.yaml
- name: Checkout code
uses: actions/checkout@v2
with:
fetch-depth: 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see

@facundobatista facundobatista merged commit e1566ae into PyAr:master Dec 21, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facundobatista facundobatista facundobatista approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenrui333 @facundobatista