Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli synonyms for --get-venv-dir and --check-updates #422

Merged
merged 5 commits into from
Feb 7, 2024

Conversation

r-ushil
Copy link
Contributor

@r-ushil r-ushil commented Feb 2, 2024

A quick change to address the following issues:

Copy link
Member

@facundobatista facundobatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, this is great, thanks!!!

A couple of minor changes, I need to ask you:

  • please move to --where the recommendation in the help message for --rm (in main.py), as the former should be the recommended way
  • similarly, improve the README.rst file (which is the docs file)
  • also annotate -U and --where as options in that file
  • add yourself to the AUTHORS file (in alphabetical order)

Thanks!!!

@r-ushil
Copy link
Contributor Author

r-ushil commented Feb 6, 2024

Thanks Facundo, I've pushed the suggested changes. Let me know if this looks good!

Copy link
Member

@facundobatista facundobatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thanks!!

@facundobatista facundobatista merged commit 353b97e into PyAr:master Feb 7, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants