Pq to class #404
Merged
Pq to class #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akollgaa
reviewed
May 29, 2024
| def __str__(self) -> str: | ||
| s = '[' | ||
| for idx, item in enumerate(self.queue): | ||
| s += f'(idx: {idx}, priority: {item.priority}, {item.contents})' |
There was a problem hiding this comment.
Currently self.queue only seems to contain Message objects from radio_utils/message.py. The message class does not have a .contents attribute. I just wanted to point this out because you didn't seem to allude to this at all unless it is your intention to have this used for image_queue.
There was a problem hiding this comment.
good catch. We can just print out the object identifier instead of the contents
sophizhao
approved these changes
May 30, 2024
akollgaa
reviewed
May 30, 2024
| >>> heap.push(item) # pushes a new item on the heap if under limit | ||
| >>> item = heap.pop() # pops the largest item from the heap | ||
| >>> item = heap.peek() # largest item on the heap without popping it | ||
| >>> heap.heapifu() # transforms list into a heap, in-place, in linear time |
There was a problem hiding this comment.
Spelling mistake on line 12: heapifu() should be heapify()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the priority queue to be a class. Simplifies creating new queues later for image transmission. Closes #390.