Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use uv automatically when running maturin develop inside a uv-created venv #2433

Merged
merged 2 commits into from
Jan 11, 2025

Conversation

messense
Copy link
Member

Closes #2432

@messense
Copy link
Member Author

messense commented Jan 11, 2025

This change is part of the following stack:

Change managed by git-spice.

@messense messense requested a review from Copilot January 11, 2025 03:43

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/develop.rs:438

  • Potential silent error handling. If uv is not specified and an error occurs, it is ignored. Consider making this behavior explicit or documenting it clearly.
if uv { Some(Err(e)) } else { None }
@messense messense force-pushed the use-uv-automatically branch from fd3d8a2 to f4bcfa3 Compare January 11, 2025 04:29
@messense messense enabled auto-merge (rebase) January 11, 2025 05:09
@messense messense disabled auto-merge January 11, 2025 05:58
@messense messense merged commit fe88cfe into main Jan 11, 2025
40 of 66 checks passed
@messense messense deleted the use-uv-automatically branch January 11, 2025 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use uv automatically when running maturin develop inside a uv-created venv
1 participant