Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement locked iteration for PyList #4789

Merged
merged 16 commits into from
Jan 8, 2025
+454 −33
Merged

Implement locked iteration for PyList #4789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
a23499a
implement locked iteration for PyList
ngoldbaum Dec 10, 2024
6b97a56
fix limited API and PyPy support
ngoldbaum Dec 11, 2024
2ef8f17
fix formatting of safety docstrings
ngoldbaum Dec 12, 2024
b911887
only define fold and rfold on not(feature = "nightly")
ngoldbaum Dec 12, 2024
4e2fae6
add missing try_fold implementation on nightly
ngoldbaum Dec 12, 2024
0ee19bf
Use split borrows for locked iteration for PyList
epilys Dec 12, 2024
d7f6abf
use a function to do the split borrow
ngoldbaum Dec 12, 2024
6c99a5c
add changelog entries
ngoldbaum Dec 12, 2024
f56802c
fix clippy on limited API and PyPy
ngoldbaum Dec 12, 2024
0a57207
use a macro for the split borrow
ngoldbaum Dec 12, 2024
e6809f7
add a test that mutates the list during a fold
ngoldbaum Dec 13, 2024
a27288a
enable next_unchecked on PyPy
ngoldbaum Jan 6, 2025
f57bab1
fix incorrect docstring for locked_for_each
ngoldbaum Jan 6, 2025
2967b21
simplify borrows by adding BoundListIterator::with_critical_section
ngoldbaum Jan 6, 2025
994bc49
fix build on GIL-enabled and limited API builds
ngoldbaum Jan 6, 2025
5562368
fix docs build on MSRV
ngoldbaum Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions newsfragments/4789.added.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
* Added `PyList::locked_for_each`, which is equivalent to `PyList::for_each` on
the GIL-enabled build and uses a critical section to lock the list on the
free-threaded build, similar to `PyDict::locked_for_each`.
2 changes: 2 additions & 0 deletions newsfragments/4789.changed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
* Operations that process a PyList via an iterator now use a critical section
on the free-threaded build to amortize synchronization cost and prevent race conditions.
Loading
Loading