Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated enabling of MPI support #34

Merged
merged 6 commits into from
Dec 12, 2024

Conversation

juanfem
Copy link
Collaborator

@juanfem juanfem commented Nov 7, 2024

This PR makes meson configure automatically MPI support based on the presence of a valid MPICH installation.

It also includes a core/__init__.py file that automatically imports orbit-mpi when importing any other module. That initializes MPI and therefore fixes #31.

Juan F. Esteban Müller added 5 commits November 7, 2024 14:58
@juanfem juanfem requested a review from azukov November 7, 2024 15:17
@azukov
Copy link
Member

azukov commented Nov 7, 2024

This looks very nice!
@juanfem Can you check for openmpi too?

Copy link
Member

@azukov azukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check for openmpi if mpich is not available and skip mpi if neither is installed?

@juanfem
Copy link
Collaborator Author

juanfem commented Nov 7, 2024

good point, let me check

@juanfem
Copy link
Collaborator Author

juanfem commented Nov 7, 2024

done! it seems to work well either way

@azukov azukov merged commit ac20928 into PyORBIT-Collaboration:main Dec 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MPI issue with 2D space charge nodes
2 participants