Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the sanitization function to a asyncio.to_thread #44

Merged
merged 2 commits into from
May 20, 2024

Conversation

EvieePy
Copy link
Member

@EvieePy EvieePy commented May 18, 2024

Description

Allows bleach to run in a asyncio.to_thread.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
    • I have updated the changelog with a quick recap of my changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)
  • I have read and agree to the Developer Certificate of Origin for this contribution

Copy link
Member

@LostLuma LostLuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be better to highlight all files at once in a single asyncio.to_thread call instead?

@EvieePy
Copy link
Member Author

EvieePy commented May 20, 2024

Might be better to highlight all files at once in a single asyncio.to_thread call instead?

Yeah this makes sense

@LostLuma LostLuma merged commit ba8f937 into main May 20, 2024
2 checks passed
@LostLuma LostLuma deleted the fix/bleach-asyncio branch May 20, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants