minor update

QED-it · Apr 29, 2024 · e6d1dbe · e6d1dbe
1 parent b02478a
commit e6d1dbe
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 6 deletions.
diff --git a/halo2_gadgets/src/sinsemilla/merkle.rs b/halo2_gadgets/src/sinsemilla/merkle.rs
@@ -407,7 +407,7 @@ pub mod tests {
 
         let circuit = MyCircuit::default();
         halo2_proofs::dev::CircuitLayout::default()
-            .show_labels(true)
+            .show_labels(false)
             .render(11, &circuit, &root)
             .unwrap();
     }

diff --git a/halo2_gadgets/src/sinsemilla_opt/merkle.rs b/halo2_gadgets/src/sinsemilla_opt/merkle.rs
@@ -239,7 +239,7 @@ pub mod tests {
 
         let circuit = MyCircuit::default();
         halo2_proofs::dev::CircuitLayout::default()
-            .show_labels(true)
+            .show_labels(false)
             .render(11, &circuit, &root)
             .unwrap();
     }

diff --git a/halo2_gadgets/src/utilities_opt/lookup_range_check.rs b/halo2_gadgets/src/utilities_opt/lookup_range_check.rs
@@ -31,8 +31,6 @@ pub struct LookupRangeCheckConfigOptimized<F: PrimeFieldBits, const K: usize> {
     base: LookupRangeCheckConfig<F, K>,
     q_range_check_4: Selector,
     q_range_check_5: Selector,
-    // FIXME: Instead of making it pub, add a method in LookupRangeCheckConfig that returns table_range_check_tag
-    //pub(crate)
     table_range_check_tag: TableColumn,
 }
 
@@ -63,7 +61,6 @@ impl<F: PrimeFieldBits, const K: usize> LookupRangeCheckConfigOptimized<F, K> {
         let q_range_check_4 = meta.complex_selector();
         let q_range_check_5 = meta.complex_selector();
 
-        // FIXME: q_range_check_4 and q_range_check_5 need to be created here
         // if the order of the creation makes a difference
         let config = LookupRangeCheckConfigOptimized {
             base: LookupRangeCheckConfig {
@@ -83,7 +80,6 @@ impl<F: PrimeFieldBits, const K: usize> LookupRangeCheckConfigOptimized<F, K> {
         meta.lookup(|meta| {
             let q_lookup = meta.query_selector(config.base.q_lookup);
             let q_running = meta.query_selector(config.base.q_running);
-            // FIXME: q_range_check_4 and q_range_check_5 need to be created here
             // if the order of the creation makes a difference
             let z_cur = meta.query_advice(config.base.running_sum, Rotation::cur());
             let one = Expression::Constant(F::ONE);