[ZIP-233] Network Sustainability Mechanism: Burning #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utChangeStrategy` doc comments more accurate concerning the choice of output pool. Signed-off-by: Daira-Emma Hopwood <[email protected]>
These operations are unused, and block heights form a vector space, not a monoid.
zcash_client_sqlite: Add missing test of `utxos_to_txos` migration.
…dition
zcash_protocol: Remove impl {Add, Sub} for BlockHeight
zcash_protocol: Set the public testnet activation height for NU6
Release zcash_protocol version 0.3.0
Release zcash_address version 0.5.0
Release zcash_primitives version 0.17.0
release zcash_proofs version 0.17.0
In contrast to the implementation of `Sub<BlockHeight> for BlockHeight` that was removed in version `0.3.0`, a saturating subtraction for block heights having a return type of `u32` makes sense for `BlockHeight`. Subtracting one block height from another yields the delta between them. Other block height addition and subtraction operations have been made saturating, removing panics and the possibility of overflow.
The `FALSE` constant was introduced in sqlite version 3.23.0, but Android does not support this version of sqlite until API level 30; we support back to Android API 27 so we have to use `0` as the constant for `FALSE` instead.
Add correct `BlockHeight` subtraction & remove panics.
zcash_keys: Add `decode_extfvk_with_network`
The `reserve_until` method for generating ephemeral addresses is used in database migrations, but it makes no sense to use this in the case that the UFVK for an account contains no transparent component; such accounts can never be used to make ZIP 320 spends.
Release zcash_protocol version 0.4.1
Release zcash_proofs version 0.20.0
Release zcash_keys version 0.5.0
…-0.15.0 Release zcash_client_backend version 0.15.0
…0.13.0 Release/zcash client sqlite 0.13.0
Release zcash_primitives version 0.20.0
…`AccountUuid` This requires a few annoying changes to migrations in order to avoid hitting cases where account UUIDs are expected before they exist in the database schema.
This is now consistent with how we name other internal primary key type wrappers.
Co-authored-by: Daira-Emma Hopwood <[email protected]>
zcash_client_sqlite: Assign UUIDs to each account
… UFVKs with spending purpose.
…_metadata zcash_client_backend: Add optional derivation metadata when importing UFVKs with spending purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the
librustzcashchanges required for ZIP-233 (NSM - Burning), which adds a transaction field forburnAmount. This is essentially a copy of zcash#1567 that I'm posting here for convenience. Unfortunately this also includes a diff with upstream. I briefly tried rebasing on thezsa1branch, but it looks like it could be messy. However, I can take some time to do this if you'd rather not merge with upstreamlibrustzcashat this time?