Add dockerfile for the demo client #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeykoren
requested changes
Jul 22, 2024
Dockerfile-demo
Outdated
| ENV ZCASH_NODE_PROTOCOL=http | ||
|
|
||
| # Set the entrypoint | ||
| ENTRYPOINT ["cargo", "run", "--package", "zcash_tx_tool", "--bin", "zcash_tx_tool", "test"] |
There was a problem hiding this comment.
For demo docker probably --release is a good idea because of performance
README.md
Outdated
| To build and run the docker image: | ||
| To build and run the docker image, make sure you create the network first: | ||
| ```bash | ||
| docker network create zcash-network |
There was a problem hiding this comment.
Network is not really a requirement in non-docker client case. Shall we move it to demo-related setup?
README.md
Outdated
| And after that run the image itself. | ||
| The default connection parameters are set to connect to the zebra-node running on the machine itself (12.0.0.1) | ||
| If you ran the node in a docker container with the command above, you named that container "zebra-node", so you should use that as the ZCASH_NODE_ADDRESS. | ||
| If the node is running on the ECS server, you can connect to it by setting the ZCASH_NODE_ADDRESS=dev.zebra.qedit-solana.net. |
There was a problem hiding this comment.
Should this url be a part of a public readme? Looks like part of our internal config, also with non-obvious relations to Solana
There was a problem hiding this comment.
Wasn't aware it was Public, removed
alexeykoren
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.